Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a combined skip attribute #935

Merged
merged 1 commit into from
May 16, 2017
Merged

Add a combined skip attribute #935

merged 1 commit into from
May 16, 2017

Conversation

spikefoo
Copy link
Contributor

@spikefoo spikefoo commented May 16, 2017 •
edited by oli-obk

fixes #931

I added a combined skip field attribute.

If this looks fine, I'll add a combined skip variant attribute too.

@spikefoo
Copy link
Contributor Author

I'm not adding a combined skip variant attribute for now, because it appears skip_serializing and skip_deserializing have orthogonal behavior as variant attributes, at least with bincode: bincode#184.

cc @dtolnay

@dtolnay dtolnay merged commit e792874 into serde-rs:master May 16, 2017
@spikefoo spikefoo deleted the combined-skip branch May 17, 2017 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn when using only one of skip_serializing and skip_deserializing
3 participants
@spikefoo @oli-obk @dtolnay