Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

still issues with SauceLabs in serenity 2.0.18 #1468

Closed
enortonAtAdobe opened this issue Nov 28, 2018 · 9 comments
Closed

still issues with SauceLabs in serenity 2.0.18 #1468

enortonAtAdobe opened this issue Nov 28, 2018 · 9 comments

Comments

@enortonAtAdobe
Copy link
Contributor

Thanks for the fix for #1455 in commit 3dd499e

However, there appears to be more changes required per the document https://wiki.saucelabs.com/display/DOCS/Selenium+W3C+Capabilities+Support+-+Beta#SeleniumW3CCapabilitiesSupport-Beta-CheckingforUseofNewCapabilities than just the file called out in the original issue. As now with serenity 2.0.18, it is no longer possible to execute tests in Chrome browser (Firefox did work).

SauceLabs suggested: Can you try setting "w3c" to true in chromeOptions? See the note on this at https://wiki.saucelabs.com/display/DOCS/Selenium+W3C+Capabilities+Support+-+Beta

I am not familiar with where all the SauceLabs or browser driver related api calls are in Serenity to itemize where calls need to be udpated based on that wiki. And I'm also not certain the current suggestion from SauceLabs is the only further change needed.

@enortonAtAdobe enortonAtAdobe changed the title still issues with SauceLabs still issues with SauceLabs in serenity 2.0.18 Nov 28, 2018
@wakaleo
Copy link
Member

wakaleo commented Nov 28, 2018

Can you try out some changes in the SaucelabsRemoteDriverCapabilities class and propose a PR?

@enortonAtAdobe
Copy link
Contributor Author

I can give it a try :) I think that that might not be the only class that needs updating though. It might take me some time too.

@maheshkukrani
Copy link

hey guys, i ran into the same issues while upgrading the serenity version from 2.0.15 to latest(2.0.48). i opened another issue but after debugging and looking into this issue i realized you guys already gave it a try to add the experimental options. So do i need to set this manually as for saucelabs w3c should be true ? I see that you support both saucelabs and browserstack and hence you cannot set them to default ?

@maheshkukrani
Copy link

maheshkukrani commented May 18, 2019

Ok more update - so for chrome adding this in serenity.properties solves it - chrome.experimental_options.w3c=true
About firefox...on more research i see that this needs to be modified- FirefoxDriverCapabilities.java
to add an option for user to set the capability w3c for firefox. some thing like an environment variable- firefox.capabilities.w3c. I have very little experience in this project otherwise i would give it a try to create a PR myself.

@enortonAtAdobe
Copy link
Contributor Author

I was able to get this working for all browsers, with the following properties:
saucelabs.platform="${PLATFORM}"
saucelabs.browserName=${BROWSER}
saucelabs.browser.version=${BROWSER_VERSION}

@maheshkukrani
Copy link

Referring #1678 for all the combinations i had tried. i tried your suggestion too but it doesn't work.
so this is what i set exactly-

saucelabs.url=********
saucelabs.test.name=test
saucelabs.platform=macOS 10.12
saucelabs.browserName=firefox
saucelabs.browser.version=66
saucelabs.access.key=*******
saucelabs.user.id=*********

@enortonAtAdobe
Copy link
Contributor Author

Sorry - one other property we specify: saucelabs.seleniumVersion=3.141.59
We've got this set in the serenity.properties file:

@enortonAtAdobe
Copy link
Contributor Author

note too, this seleniumVersion corresponds to the one we specify in our java project via our maven pom file as well

@maheshkukrani
Copy link

maheshkukrani commented May 24, 2019

Gr8, this worked fine!. i haven't tested it for all browsers but at least that i was trying worked. Thanks

@wakaleo wakaleo closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants