Add more details in certain cases of UnrecognisedException

[MosheElisha]

Hi,

When a UnrecognisedException is thrown from net.thucydides.core.model.stacktrace.FailureCause#restoreExceptionFrom, it sometimes misses the details in case "buildThrowable" method does not support it.

When such unrecognized exceptions occur, the report simply shows "Unrecognised exception" which is not very beneficial.

We can easily add more info to UnrecognisedException by doing something like:

new UnrecognisedException(testFailureClassname + ": " + testFailureMessage);

in both places:

1. serenity-core/serenity-model/src/main/java/net/thucydides/core/model/stacktrace/FailureCause.java

   Line 169 in f8ef5b9

   exception = new UnrecognisedException();

2. serenity-core/serenity-model/src/main/java/net/thucydides/core/model/stacktrace/FailureCause.java

   Line 174 in f8ef5b9

   Throwable exception = new UnrecognisedException();

[wakaleo]

Good idea - could you propose a PR?

[MosheElisha]

Thanks. Sure.

[MosheElisha]

Hi,

I want to work on the PR so I followed the instructions and followed the "How to build" but when running the tests (before making any changes) the tests failed on:

shouldProvideAccessToAngularLocatorsAndWaitForAngularToFinish

net.thucydides.core.webdriver.UnsupportedDriverException: Could not instantiate new WebDriver instance of type class org.openqa.selenium.firefox.FirefoxDriver (Timed out waiting 45 seconds for Firefox to start.
Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03'
System info: host: 'me-dev-0-server', ip: '192.168.1.23', os.name: 'Linux', os.arch: 'amd64', os.version: '3.10.0-862.14.4.el7.x86_64', java.version: '1.8.0_191'
Driver info: driver.version: FirefoxDriver

When I run "firefox" command it works fine and even when the tests were running, firefox did start automatically.

Can you please assist? Should I raise a different issue for this?

[wakaleo]

Thanks for trying. What the instructions don't mention is that you need to have an up-to-date version of chromedriver, geckodriver and phantomjs on your system path for the integration tests.