-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serenity reports shows 0 steps but test passed if junit.Assume is used in before method #1562
Comments
This would be in the JUnitRunner class in serenity-junit, which I don't think would know what to do with an Assume failure, so it must just ignore it but not trigger the correct outcome in the StepEventBus. Please feel free to take a look. |
@wakaleo Thanks. Unfortunately, couldn't find easy tweak. Will try to back to it later. |
Additional info which may help: I have also noticed that the results.csv download icon has also 'disappeared' from the serenity report home page when this issue manifests itself. But I can see the results.csv is present in the correct serenity folder. https://github.com/serenity-bdd/serenity-core/#what-is-the-latest-stable-version-i-should-use |
@wakaleo |
No |
You are commenting on a closed issue relating to an old version of Serenity - you might need to provide some more details about the problem you are having. |
Hello guys,
We will be very glad if you can help with a fix or point out the place where it can be fixed.
We want to ignore some tests based on some conditions via before method. If you use "junit.Assume" which doesn't match condition then the test is marked as ignored in JUnit as expected (standard usage of this method). This is quite common way of ignoring tests in JUnit and it works perfect in case you use just JUnit itself. But serenity report shows this test as passed anyway having 0 steps inside.
How we ignore:
@Before public void beforeMethod() { org.junit.Assume.assumeTrue(someCondition()); }
Serenity report:
The text was updated successfully, but these errors were encountered: