Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypted password in JiraJerseyClient #1575

Closed
timothyjmtan opened this issue Feb 13, 2019 · 2 comments
Closed

Encrypted password in JiraJerseyClient #1575

timothyjmtan opened this issue Feb 13, 2019 · 2 comments

Comments

@timothyjmtan
Copy link
Contributor

Hi,

Currently in our company we are using a common password for all enterprise applications. Such applications include assessing your payroll, JIRA, etc.

As you can imagine, it's not a very good idea to reveal this password, as a curious cat who may have your password ("for JIRA purposes only") has access to your payroll details.

In our usage of JiraJerseyClient we are connecting to JIRA. It is possible to watch an instantiated object to spy on the plaintext password. We have tried encrypting this password in our framework, but even then the object still reveals the decrypted password.

Is there a way to prevent plaintext passwords from showing at all?

@wakaleo
Copy link
Member

wakaleo commented Feb 13, 2019

A very good point. I don't have bandwidth to look at this at the moment, but https://github.com/serenity-bdd/serenity-jira/blob/master/serenity-jira-plugin/src/main/java/net/serenitybdd/plugins/jira/client/JerseyJiraClient.java is the class you would need to modify to integrate some form of encryption (I don't think it would be hard to do).

@timothyjmtan
Copy link
Contributor Author

Cool, thanks! I'll take a look and raise a PR if I managed to fiddle with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants