Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty line printed in console when grabbing screenshot #1676

Closed
Azer249 opened this issue May 15, 2019 · 3 comments
Closed

Empty line printed in console when grabbing screenshot #1676

Azer249 opened this issue May 15, 2019 · 3 comments

Comments

@Azer249
Copy link

Azer249 commented May 15, 2019

private List<ScreenshotAndHtmlSource> grabScreenshots(TestResult result) {
System.out.println();

Not sure if this is intentional, but it looks like the BaseStepListener.grabScreenshots(..) method is just printing an empty line for no reason. It caused a bit of confusion when executing tests as it wasn't initially clear where this blank line was coming from.

@wakaleo
Copy link
Member

wakaleo commented May 15, 2019

Yep, that shouldn't be there. I'll remove it for the next release (or you can provide a PR if you prefer to get the credit).

@Azer249
Copy link
Author

Azer249 commented May 15, 2019

No worries about the credit, go ahead and make the change 👍

Thanks!

@wakaleo
Copy link
Member

wakaleo commented Jun 1, 2019

Fixed in 2.0.49

@wakaleo wakaleo closed this as completed Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants