Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot controlling -- which comes first? #1700

Closed
timothyjmtan opened this issue Jun 10, 2019 · 2 comments
Closed

Screenshot controlling -- which comes first? #1700

timothyjmtan opened this issue Jun 10, 2019 · 2 comments
Labels

Comments

@timothyjmtan
Copy link
Contributor

timothyjmtan commented Jun 10, 2019

Hi there,

I'm on Screenplay for my project.

Assuming I have the below class which implements both Task and an empty interface called NoScreenshot.

public class A implements Task, NoScreenshots

And in serenity.properties I do the following:
serenity.take.screenshots=AFTER_EACH_STEP
serenity.take.screenshot.for.noscreenshots=DISABLED

How does the framework resolve this conflict of Task taking screenshots after each step, but NoScreenshot defining it as disabled?

Based on my test, it seems like screenshots are still being taken when class A is executed. I'm trying to find a way to disable screenshots just for this class, but all Tasks should take screenshots as per defined. Thanks!

@timothyjmtan
Copy link
Contributor Author

timothyjmtan commented Jul 5, 2019

Hi, any ideas on the issues above please? :-)
Any advice would be appreciated.

@wakaleo
Copy link
Member

wakaleo commented Jul 22, 2019

I think serenity.take.screenshot.for.noscreenshots should take priority, but the best way to check would be to see what the code is doing in the BaseStepListener class (in the take() method).

@wakaleo wakaleo closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants