Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serenity report marks a scenario with ignored step as passed #1765

Closed
shailysingh opened this issue Aug 7, 2019 · 2 comments
Closed

Serenity report marks a scenario with ignored step as passed #1765

shailysingh opened this issue Aug 7, 2019 · 2 comments

Comments

@shailysingh
Copy link

In case of cucumber.runtime.AmbiguousStepDefinitionsException, the overall scenario is being reported as PASSED even though the impacted step is displayed as IGNORED with a small message below the ignored step - Then validation message prohibiting delete action is displayed. (screenshot attached)

Shouldn't this scenario be displayed as PENDING?

The scenario being displayed as PASSED confuses the testers, since PENDING/FAILED/BROKEN scenarios get quicker attention. PASSING scenarios are left untouched unless there is a need to change them.

Versions:
java.version: '1.8.0_212'
<serenity.version>2.0.24</serenity.version>
browserVersion: 76.0.3809.87
chromedriverVersion: 76.0.3809.68
platform: LINUX
We are using Zalenium containers to run our tests

ignored step but successful scenario

@wakaleo
Copy link
Member

wakaleo commented Aug 7, 2019

I have never encountered this case - generally an ambiguous step will crash the build. But I'm happy to review a PR if you would like to propose a fix.

@shailysingh
Copy link
Author

@wakaleo Now when I think of it, you are right. I have seen the build crash in the past because of ambiguous step. Not sure if this is already an open issue with Cucumber. I will check there first.

@wakaleo wakaleo closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants