Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presence of comments in JBehave scenarios make test scenario execution status as ‘ignored/skipped’ #2006

Closed
YuliaPrysiazhniuk opened this issue Mar 23, 2020 · 6 comments
Labels

Comments

@YuliaPrysiazhniuk
Copy link

Steps to reproduce:

  1. Created a sample project using latest available Serenity JBehave Archetype (v 2.0.91) which is based on <serenity.version>2.0.48.
  2. Add comments in any of sample test scenarios and run the test. Test status will be passed.
  3. Update Serenity version to the latest one - 2.1.13. Run the same testcase. Result: test status will be ‘ignored/skipped’.
@wakaleo
Copy link
Member

wakaleo commented Apr 1, 2020

I don't think anything has changed in the Serenity code for this, so maybe a JBehave issue.

@pdevaraj714
Copy link

Reviving this thread, I am also facing a similar issue with the presence of comments making the final results of tests to become ignored, even if every step in the jbehave story is passed.

Please find the versions of serenity and dependencies used below(maven build tool):
<serenity.version>3.1.15</serenity.version>
<serenity.maven.version>3.1.15</serenity.maven.version>
<serenity.jbehave.version>1.46.0</serenity.jbehave.version>

<java.version>1.8</java.version>
<junit.version>4.12</junit.version>

<maven-surefire-plugin.version>3.0.0-M5</maven-surefire-plugin.version>
<maven-compiler-plugin.version>3.8.1</maven-compiler-plugin.version>
<maven-shade-plugin.version>3.2.4</maven-shade-plugin.version>

@wakaleo
Copy link
Member

wakaleo commented Dec 30, 2021

It might be a problem parsing the JBehave story file when the requirements module in Serenity reads it. We don't really actively support JBehave specifically these days for the more recent versions of Serenity, but if you want to have a look at the code, please feel free to have a look at net.thucydides.core.requirements.model.LoadedNarrative

@pdevaraj714
Copy link

Hi John, thanks for the reply. Does that mean we will have to revert back to previous version of serenity to maintain jbehave support? The previous version that we were using was serenity 2.0.53. Please also find a screenshot of how the report looks like for reference. Thanks.
image

@wakaleo
Copy link
Member

wakaleo commented Dec 30, 2021

I suspect comments in JBehave stories may always have caused problems.

@wakaleo
Copy link
Member

wakaleo commented Feb 13, 2022

Closing as JBehave is not specifically supported in Serenity 3.x.

@wakaleo wakaleo closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants