Serenity summary file alignment is not correct

[ahuja-ankur]

Hi,

When I used Email-ext plugin to send the serenity-summary.html to my gmail box. It is distorted. The same project is https://github.com/ahuja-ankur/sample-Proj.git

Please help.

[wakaleo]

Does it work when you display the report locally?

[ahuja-ankur]

yes, when I open the file in browser normally, it works fine. See below -

[wakaleo]

Have you tried sending the original report as an html document to your gmail client?

[wakaleo]

HTML rendering is notoriously unreliable in email clients, so it could be an issue with the rendering (which will be hard to fix, as fixing the rendering for one client will break it for another, or may not be possible at all).

[ahuja-ankur]

Have you tried sending the original report as an html document to your gmail client?

I am sending as HTML only.

[wakaleo]

The other possibility is that the email-ext plugin modifies the html (that would seem unlikely but worth checking)

[ahuja-ankur]

HTML rendering is notoriously unreliable in email clients, so it could be an issue with the rendering (which will be hard to fix, as fixing the rendering for one client will break it for another, or may not be possible at all).

It is working fine for old versions of serenity.

[wakaleo]

If you can figure out a modification of the HTML that would render correctly, I can have a look at the template to see if it is possible.

[globalworming]

if you could precisely state the version where it breaks, we could check the commits for what may be the culprit

[ahuja-ankur]

If you can figure out a modification of the HTML that would render correctly, I can have a look at the template to see if it is possible.

I can say it is working fine for serenity-emailer version 1.9.45 but not for 2.2.5... Probably this could help you in comparing.

[ahuja-ankur]

if you could precisely state the version where it breaks, we could check the commits for what may be the culprit

Working fine in 1.9.45 but not in 2.2.5

[globalworming]

that's not very precise :)

[ahuja-ankur]

that's not very precise :)

After 1.9.45, I checked at 2.0.40. There also it is broken... I am not able to go below this version because then I have to lower down all my dependencies

[wakaleo]

If you can identify an exact version change we can see what has changed.

[ahuja-ankur]

If you can identify an exact version change we can see what has changed.

Would it be possible for you to compare the two versions I provided, because ultimately the fix would be on top of latest version.

[ahuja-ankur]

for serenity-single-page-report, it is issue from first version for me... earlier I was using serenity-emailer 1.9.45

[wakaleo]

It’s just the artifact name that changed, the code should be similar. See if you can isolate the exact change

[ahuja-ankur]

ok, let me try quickly

[ahuja-ankur]

It’s just the artifact name that changed, the code should be similar. See if you can isolate the exact change

It is exact 2.0.4 and 2.0.5 version where the format has changed. I hope it helps.

[wakaleo]

There are about 50 releases between 1.9.45 and 2.0.0

[ahuja-ankur]

that's not very precise :)

It is exact 2.0.4 and 2.0.5 version where the format has changed. I hope it helps.

[ahuja-ankur]

There are about 50 releases between 1.9.45 and 2.0.0

It is exact 2.0.4 and 2.0.5 version where the format has changed. I hope it helps.

[wakaleo]

That does help. I don’t know when I will be able to look at it, though - if you can look at the differences in GitHub and propose a PR it will be quicker

[ahuja-ankur]

That does help. I don’t know when I will be able to look at it, though - if you can look at the differences in GitHub and propose a PR it will be quicker

can you please help in confirming exactly where to look at. I am new to this.

[globalworming]

with you IDE it should be easy to check out a the branches tagged v2.0.4 and v2.0.5 and compare them (at least my IntelliJ does this pretty good). changes in the emailable html report are most important i guess

[ahuja-ankur]

I tried to push my branch to create pull request but it is giving me permission denied...
Please help..

[wakaleo]

You’ll need to raise a Pull Request

[ahuja-ankur]

You’ll need to raise a Pull Request

how, when I cannot push my branch. I created the branch locally but when pushing it is giving me error -

[wakaleo]

See https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests

You need to fork the repository, make and test your change locally, then propose a Pull Request against the main repo

[ahuja-ankur]

Raised PR #2112. Please take a look.

[ahuja-ankur]

@wakaleo Thanks for merging the PR, it looks like it will be part of 2.2.9, so when 2..29 is expected to be rolled out? because I would like to get this soon.

[ahuja-ankur]

Raised PR #2113 for minor modifications. Please merge.

[wakaleo]

There will be a new release early next week.

[ahuja-ankur]

Issue not occurring in 2.2.9. Fix is good. Closing this thread.