Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override description of built-in interactions #2254

Closed
ricardorlg-aval opened this issue Oct 5, 2020 · 5 comments
Closed

Allow override description of built-in interactions #2254

ricardorlg-aval opened this issue Oct 5, 2020 · 5 comments

Comments

@ricardorlg-aval
Copy link

The idea is to allow users to change the description of the Serenity built-in interactions. My initial idea after reviewing the current implementation is to provide a way so the users give us a properties file with the name of the interactions that would like to override, for example:

ClickOnTarget: "{0} have click en #target"

And then when getting the step name, we will see if the user wants to override the current interaction, if so we will load the value and provide that name.

@wakaleo what do u think about this approach, u can assign this to me, so I can make a POC for review.

@globalworming
Copy link
Collaborator

Can't you just extend the ClickOnTarget class and provide your own ..title?.. through annotations?

@ricardorlg-aval
Copy link
Author

ricardorlg-aval commented Oct 5, 2020

yes but I should have to extend all interactions implements all performAs to add my Step annotation and just make super calls.

@globalworming
Copy link
Collaborator

feel free to do a POC.. i am not sure how useful this is to me personally. something like "click on X" provides the info I need..

why do you want to change that? if it's one specific case you can propose a better wording?

@ricardorlg-aval
Copy link
Author

The use case is non English users, some folks writes acceptance tests in Spanish for example then they have to deal with the fact of English and Spanish in the report.

@globalworming
Copy link
Collaborator

globalworming commented Oct 8, 2020

sounds like an internationalization issue, we could fix that with i18n tools. i am currently building a html report based on react. we could just add different translation resources there. How good is your javascript? :) https://github.com/globalworming/serenity-report-navigator

@wakaleo wakaleo closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants