Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit Timeout @Rule causes Serenity steps to be omitted from the Serenity report #2397

Closed
adeellis opened this issue Mar 4, 2021 · 0 comments

Comments

@adeellis
Copy link

adeellis commented Mar 4, 2021

Issue with using in later versions of Serenity causes steps to be omitted from the report. Does not happen in versions 2.2.5 and earlier.

Here is the junit rule: -

@Rule
public Timeout scenarioTimeout = Timout.seconds(20L);

I have 0 steps showing on my report but all tests have passed. I am running a project with JUnit tests only (no cucumber tests, no cucumber dependencies in the pom). If I use serenity versions 2.1.6, 2.2.0, 2.2.2, 2.2.5 the steps show correctly on the report when I drill into them. The steps disappear in later versions. If I run the same project with a later version of serenity e.g. 2.2.12 (with no changes made to my project) the steps show as 0 in the report. The tests still all are running successfully as I can see them in the console and on the report home page the number of tests is reported correctly. If you attempt to drill into a test to view the steps they are missing.

I have also noticed that the results.csv download icon has also 'disappeared' from the serenity report home page when this issue manifests itself. But I can see the results.csv is present in the correct serenity folder.

EDIT: could it be related to the change to use thread local variables in JUnitStepListener in 2.2.10?

@wakaleo wakaleo closed this as completed Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants