What is the best way to create custom wait for progress bar/loader on screen in screenplay

[atulkumar94]

I'm using below action to create custom wait for progress bar/loader to disappear but even when loader is disappeared, code still waits for 30s timeout. Can somebody please help?

public class WaitForSpinLoader implements Interaction {
        @Step("User waits for loader to disappear")
        @Override
        @Screenshots(disabled = true)
        public <T extends Actor> void performAs(T actor) {
            WebDriverWait wait = new WebDriverWait(BrowseTheWeb.as(actor).getDriver(),
                10);
            wait.until(new ExpectedCondition<Boolean>() {

                @Override
                public Boolean apply(WebDriver driver) {
                    if (CurrentVisibility.of(CommonPage.spinner).viewedBy(actor).asBoolean()) {
                        return false;
                    } else {
                        return true;
                    }
                }
            });
        }
}

In Serenity.properties I'm using webdriver.timeouts.implicitlywait = 30000.

Note: I'm using this approach as progress bar/loader appears randomly.

[atulkumar94]

@wakaleo can you please let me know if anything is wrong with this action?

[Rangiferus]

Why not waiting for it in the standard way like this:

actor. attemptsTo(
   WaitUntil.the(CommonPage.spinner, isNotVisible()).forNoMoreThan(10).seconds())
);