serenity-junit5 depends on junit4 classes

[zeners]

the artifact net.serenity-bdd:serenity-junit5:3.1.20.jar contains the classes

• PendingTestException
• SkippedTestException

which both extends the junit4 class org.junit.AssumptionViolatedException instead of org.opentest4j.TestAbortedException, like the org.junit.jupiter.api.Assumptions#throwTestAbortException use on assumption violation.

[wakaleo]

Well spotted. Can you propose a PR?

[zeners]

yes .. will take a moment ...

[zeners]

and done

is there any chance to get rid of
import static org.junit.Assert.assertTrue;
in PredicateConsequence?

[wakaleo]

Why do you want to get rid of it?

[zeners]

it's the last dependency to junit4 in our use-case

currently i excluded junit4 (with own Assert.assertTrue, forwading to junit5 Assertions.assertTrue) to ensure all Tests are of junit5 and developers are not irritated in choosing the 'correct' @Test annotation.

[zeners]

in the meantime done by 56cb636
great thanks