Problem using @DisabledIfSystemProperty

[ztztzt8888]

We have existing API tests using annotations such as

@DisabledIfSystemProperty(named = "environment", matches = "prod")

When we add serenity to the dependency (latest version 3.4.2) the unrelated tests with the tags above start to skip regardless of the environment it was running in. So basically they all stopped running in our nightly build for all environment.

The SkippedTestException was thrown at net.serenitybdd.junit5.SerenityJUnit5Extension.lambda$afterEach$1(SerenityJUnit5Extension.java:74)

[ztztzt8888]

It was thrown by this method

>  @Override
>     public void afterEach(ExtensionContext context) {
>         if (!StepEventBus.getEventBus().isBaseStepListenerRegistered()) {
>             LOGGER.warn("NO BASE STEP LISTENER FOUND IN THREAD " + Thread.currentThread());
>         }
>         TestOutcome outcome = StepEventBus.getEventBus().getBaseStepListener().getCurrentTestOutcome();
>         String methodName = outcome.getQualifiedMethodName();
>         context.getTestMethod().ifPresent(
>                 method -> {
>                     // Make sure it's the right test - not sure when this gets called in parallel testing.
>                     if (method.getName().equals(methodName)) {
>                         // Failing test
>                         if (outcome.getTestFailureCause() != null) {
>                             throw outcome.getTestFailureCause().asRuntimeException();
>                         } else if (outcome.isPending()) {
>                             throw new PendingTestException(context.getDisplayName());
>                         } else if (outcome.isSkipped()) {
>                             throw new SkippedTestException(context.getDisplayName());
>                         }
>                     }
>                 }
>         );
>     }

[wakaleo]

Well spotted. Can you propose a PR?

[wakaleo]

Can you provide a sample project to reproduce this?