Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get multiple properties from EnvironmentSpecificConfiguration fails #3425

Open
AndreasScharfCPB opened this issue Mar 27, 2024 · 1 comment

Comments

@AndreasScharfCPB
Copy link

Hi,

I believe this line is not correct. The negation is wrong. At least if I am understanding the method correctly.
Also tested it an if I remove the negation I can successfully call
EnvironmentSpecificConfiguration.from(environmentVariables).getPropertiesWithPrefix("propPart1.propPart2");
...and it gets me all the sub-properties for that envronment for the specific root key "propPart11.propPart2"
https://github.com/serenity-bdd/serenity-core/blame/08725f0135fd80ddbb1cb7abf904bbcbb864b8a3/serenity-model/src/main/java/net/serenitybdd/model/environment/EnvironmentSpecificConfiguration.java#L67

Thank you for your support.

@wakaleo
Copy link
Member

wakaleo commented May 24, 2024

Changing this line breaks the tests in https://github.com/serenity-bdd/serenity-core/blob/main/serenity-model/src/test/groovy/net/serenitybdd/model/environment/WhenDefiningBaseUrlsForDifferentEnvironments.groovy. Have a look at those tests and see if you can come up with a PR that supports the behaviour you are after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants