Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: URL to book is broken #70

Open
jenisys opened this issue Aug 19, 2023 · 4 comments
Open

README: URL to book is broken #70

jenisys opened this issue Aug 19, 2023 · 4 comments

Comments

@jenisys
Copy link

jenisys commented Aug 19, 2023

The README (of this Git repository) refers to the following URL for the serenity-book (latest):

Which causes a 404 legacy URL error.

PROBABLY SHOULD BE (or something similar):

EXPECTED (one of):

  • FIX and CORRECT the broken hyperlink in the README
  • Remove the broken hyperlink from the README
@wakaleo
Copy link
Member

wakaleo commented Aug 19, 2023

Well spotted - can you propose a PR?

@jenisys
Copy link
Author

jenisys commented Aug 19, 2023

I can provide one if I know the correct URL.

From quickly browsing for it:

  • Either the book publishing is no longer on https://readthedocs.org (the original URL prefix does not exist any more — First URL path part after the hostname part) or
  • The books contents are now distributed over the web site

@jenisys
Copy link
Author

jenisys commented Aug 19, 2023

@globalworming
Copy link
Collaborator

I would get rid of the magic that figures out the right legacy page https://github.com/serenity-bdd/serenity-bdd.github.io/pull/44/files don't think that's particularly useful anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants