Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber Data Tables do not appear in Serenity Report #14

Closed
joekeen opened this issue Jan 18, 2017 · 5 comments
Closed

Cucumber Data Tables do not appear in Serenity Report #14

joekeen opened this issue Jan 18, 2017 · 5 comments
Labels
@serenity-js/cucumber Adapter for Cucumber.js

Comments

@joekeen
Copy link

joekeen commented Jan 18, 2017

We use Cucumber Data Tables with out steps.

For example (from https://cucumber.io/docs/reference#data-tables):

Given the following users exist:
  | name   | email              | twitter         |
  | Aslak  | aslak@cucumber.io  | @aslak_hellesoy |
  | Julien | julien@cucumber.io | @jbpros         |
  | Matt   | matt@cucumber.io   | @mattwynne      |

The Data Table does not appear in the description of the step in the Serenity Report.

Only:

"Given the following users exist:"

@jan-molak
Copy link
Member

Hi @joekeen and thanks for reporting this issue, it seems like a bug, let me look into this.

@nbarrett
Copy link
Contributor

nbarrett commented Jan 19, 2017

I will be curious to see how this is handled as I've never seen a data table in a serenity report before. Is this a limitation with which fields in the cucumber json are passed to the serenity reporter or that serenity itself doesn't do data tables? This is quite important actually as I like to pass data tables to my then expectations steps to create a data driven tests.

@jan-molak jan-molak added the @serenity-js/cucumber Adapter for Cucumber.js label Jan 21, 2017
@jan-molak
Copy link
Member

@joekeen - please update serenity-js to the latest version, which supports both DataTable and DocString arguments of cucumber steps, as per the release notes.

@nbarrett - It's just a difference between how Cucumber reports regular step variables and the special "arguments", such as DataTables and DocStrings, which need to receive some special treatment.

Many thanks for helping make Serenity/JS even better!
Jan

@joekeen
Copy link
Author

joekeen commented Jan 23, 2017

Hi @jan-molak, I have updated and now the report includes the DataTable argument as required. Thanks for your work on Serenity/JS!

@jan-molak
Copy link
Member

Lovely, thanks for letting me know, glad that you found it useful :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@serenity-js/cucumber Adapter for Cucumber.js
Projects
None yet
Development

No branches or pull requests

3 participants