Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make many clippy warnings a hard error #169

Closed
kleinesfilmroellchen opened this issue May 21, 2022 · 2 comments · Fixed by #202
Closed

Make many clippy warnings a hard error #169

kleinesfilmroellchen opened this issue May 21, 2022 · 2 comments · Fixed by #202

Comments

@kleinesfilmroellchen
Copy link
Collaborator

In doing #168, I found a couple of ridiculous patterns, like the match for a single variant. We should probably do #[deny(clippy::all)] or at least some of the lints we find offensive so that we can automatically prevent them from getting through code review.

CC @jntrnr, is this something that sounds good? I'm very unsure as I love doing #[deny(clippy::all, clippy::pedantic, clippy::nursery)] in personal projects, which is too much here, but having the linter create hard errors is a good thing IMHO.

@sophiajt
Copy link
Collaborator

yeah I'm okay with ignoring a few of the more picky lints that don't seem to add much (like the single variant match)

@kleinesfilmroellchen
Copy link
Collaborator Author

No, I'd actually suggest making single variant match a hard error, because it creates unnecessary mental overhead and extra indentation. But we can discuss the details; I'll throw a PR later today after I have the basic integer overflow checks ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants