You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In doing #168, I found a couple of ridiculous patterns, like the match for a single variant. We should probably do #[deny(clippy::all)] or at least some of the lints we find offensive so that we can automatically prevent them from getting through code review.
CC @jntrnr, is this something that sounds good? I'm very unsure as I love doing #[deny(clippy::all, clippy::pedantic, clippy::nursery)] in personal projects, which is too much here, but having the linter create hard errors is a good thing IMHO.
The text was updated successfully, but these errors were encountered:
No, I'd actually suggest making single variant match a hard error, because it creates unnecessary mental overhead and extra indentation. But we can discuss the details; I'll throw a PR later today after I have the basic integer overflow checks ready
In doing #168, I found a couple of ridiculous patterns, like the
match
for a single variant. We should probably do#[deny(clippy::all)]
or at least some of the lints we find offensive so that we can automatically prevent them from getting through code review.CC @jntrnr, is this something that sounds good? I'm very unsure as I love doing
#[deny(clippy::all, clippy::pedantic, clippy::nursery)]
in personal projects, which is too much here, but having the linter create hard errors is a good thing IMHO.The text was updated successfully, but these errors were encountered: