New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy #178
Lazy #178
Conversation
Test failed. |
jenkins test this please |
Test failed. |
jenkins test this please |
Test failed. |
Test failed. |
Test failed. |
Test failed. |
Test failed. |
Test failed. |
Test PASSED! |
Test failed. |
Test PASSED! |
Now you can read it :) |
Test PASSED! |
Test PASSED! |
Test failed. |
@pbrunet : I am waiting for your commit update, now that we have resolved your issue ;-) |
Test failed. |
Test PASSED! |
if lazy_res <= self.max_recompute: | ||
self.result[t] = Lazy(self.result[t]) | ||
else: | ||
self.result[t] = Assignable(self.result[t]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This piece of code should use a function, so that the code (especially the test) would be shared with the test line 498.
Something like
def get_qualifier(node):
lazy_res = self.lazyness_analysis[node.id]
return Lazy if lazy_res <= self.max_recompute else Assignable
Test failed. |
Test failed. |
Test PASSED! |
What's the status of this PR? The description says "Just for jenkins to test " |
@pbrunet could you consider adding a section in |
Test PASSED! |
Test failed. |
Test PASSED! |
What about this PR? |
On Mon, Jan 13, 2014 at 01:57:35AM -0800, pbrunet wrote:
I am in the process of rewritting the whole Pythonic stuff. I would |
Test failed. |
Test failed. |
Test failed. |
Test failed. |
Test failed. |
Test failed. |
Test failed. |
Test failed. |
Test failed. |
jenkins test this please |
Test PASSED! |
... return a + 3 | ||
|
||
Result is the same but there is a temporary array. This case is detected as | ||
lazy and instead of saving the result of ``array * 5`` in ``a``, we same an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we same -> we save
@joker-eph @serge-sans-paille PR updated, review? |
Test PASSED! |
This PR looks good to me. the english of the documentation part is not perfect, but that's the pbrunet's touch :-) |
You can review it :)
enable lazy evaluation :)