Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy #178

Merged
merged 6 commits into from Feb 3, 2014
Merged

Lazy #178

merged 6 commits into from Feb 3, 2014

Conversation

pbrunet
Copy link
Collaborator

@pbrunet pbrunet commented Nov 13, 2013

You can review it :)

enable lazy evaluation :)

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/199/

@pbrunet
Copy link
Collaborator Author

pbrunet commented Nov 15, 2013

jenkins test this please

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/203/

@pbrunet
Copy link
Collaborator Author

pbrunet commented Nov 16, 2013

jenkins test this please

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/204/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/205/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/206/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/207/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/208/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/210/

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/214/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/217/

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/218/

@pbrunet
Copy link
Collaborator Author

pbrunet commented Nov 23, 2013

Now you can read it :)

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/219/

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/220/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/228/

@serge-sans-paille
Copy link
Owner

@pbrunet : I am waiting for your commit update, now that we have resolved your issue ;-)

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/232/

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/234/

if lazy_res <= self.max_recompute:
self.result[t] = Lazy(self.result[t])
else:
self.result[t] = Assignable(self.result[t])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of code should use a function, so that the code (especially the test) would be shared with the test line 498.

Something like

def get_qualifier(node):
  lazy_res = self.lazyness_analysis[node.id]
  return Lazy if lazy_res <= self.max_recompute else Assignable

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/245/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/246/

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/247/

@joker-eph
Copy link
Collaborator

What's the status of this PR? The description says "Just for jenkins to test "

@serge-sans-paille
Copy link
Owner

@pbrunet could you consider adding a section in doc/INTERNAL.rst where you describe the basics of your work, as well as illustrate it with a few examples, especially the tricky ones?

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/250/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/260/

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/262/

@pbrunet
Copy link
Collaborator Author

pbrunet commented Jan 13, 2014

What about this PR?

@serge-sans-paille
Copy link
Owner

On Mon, Jan 13, 2014 at 01:57:35AM -0800, pbrunet wrote:

What about this PR?

I am in the process of rewritting the whole Pythonic stuff. I would
really appreciate that you rebase against it once its done, it's a real
pain in the ass right now ;-)

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/272/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/273/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/274/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/275/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/276/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/278/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/279/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/287/

@joker-eph
Copy link
Collaborator

Test failed.
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/289/

@pbrunet
Copy link
Collaborator Author

pbrunet commented Jan 27, 2014

jenkins test this please

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/290/

... return a + 3

Result is the same but there is a temporary array. This case is detected as
lazy and instead of saving the result of ``array * 5`` in ``a``, we same an

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we same -> we save

@pbrunet
Copy link
Collaborator Author

pbrunet commented Jan 30, 2014

@joker-eph @serge-sans-paille PR updated, review?

@joker-eph
Copy link
Collaborator

Test PASSED!
Refer to this link for build results: http://jenkins.amini.fr:10000/job/Pythran/313/

@serge-sans-paille
Copy link
Owner

This PR looks good to me. the english of the documentation part is not perfect, but that's the pbrunet's touch :-)

joker-eph pushed a commit that referenced this pull request Feb 3, 2014
@joker-eph joker-eph merged commit 79d9b83 into serge-sans-paille:master Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants