Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] When using custom template for domain, please read DocumentRoot for acme challenge #2243

Open
snakale opened this issue Apr 19, 2022 · 2 comments

Comments

@snakale
Copy link

snakale commented Apr 19, 2022

Hi,

Firstly, thank you for this wonderful software. I am having an issue when trying to enable SSL for domains that have a different DocumentRoot from the default "$HOMEDIR/$user/web/$domain/public_html"

I get Error Code 15 when trying to enable LetsEncrypt.

Would it be possible to update the LetsEncrypt scripts to read the DocumentRoot of custom domain templates instead of having document root hardcoded in the scripts?

I see this in https://github.com/serghey-rodin/vesta/blob/master/bin/v-add-letsencrypt-domain:
well_known="$HOMEDIR/$user/web/$domain/public_html/.well-known"
acme_challenge="$well_known/acme-challenge"

But for some cases, I really need it to be
well_known="somepath_based_on_DocumentRoot_config/.well-known"
acme_challenge="$well_known/acme-challenge"

@jaapmarcus
Copy link
Contributor

If using Nginx as proxy just remove:

https://github.com/serghey-rodin/vesta/blob/956bc6697c0081ab5fdeb61cb7847bce16422d72/bin/v-add-letsencrypt-domain#L205-L212

this part and fix the if else fi statements

@snakale
Copy link
Author

snakale commented Apr 20, 2022

I am actually using just Apache. I have been searching the internet for solutions like crazy and found

https://github.com/hestiacp/hestiacp/blob/main/bin/v-add-letsencrypt-domain
image

This is what I mean. We need to implement something similar to this, where we read the config file of the domain to determine DocumentRoot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants