New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the exq invocation, use module names, not magic strings. #13

Closed

sergiotapia opened this issue Aug 27, 2016 · 1 comment

Labels

Owner

sergiotapia commented Aug 27, 2016 •

edited

c24182d#commitcomment-18803508

@akira mentioned we can use module names instead of plain strings.

Switch them out for the module names:

Bad: Exq.enqueue(Exq, "demonoid", "Magnetissimo.DownloadWorker", [url, "demonoid", "root_url"])
Good: Exq.enqueue(Exq, "demonoid", Magnetissimo.DownloadWorker, [url, "demonoid", "root_url"])

Switch it out where applicable.

The text was updated successfully, but these errors were encountered:

sergiotapia added the enhancement label

Owner Author

sergiotapia commented Jan 28, 2017

No longer applies, we're not using Exq or Redis.

sergiotapia closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment