Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add implicit wait keyword #385

Open
TrN003 opened this issue Mar 20, 2023 · 1 comment
Open

add implicit wait keyword #385

TrN003 opened this issue Mar 20, 2023 · 1 comment

Comments

@TrN003
Copy link

TrN003 commented Mar 20, 2023

This is about implementing access to the implicitly_wait function of the python appium client.

It would be nice to be able to specify an implicit wait. Explicit waits are an anti-pattern and avoiding them like this could de-clutter people's code.

I have written a minimal implementation here. To be specific, I added this function.
I would like to open a PR.

I have a few questions:

  • how can I / should I build documentation
  • should I add a mention of the explicit-wait anti-pattern in the documentation?
  • the tests are failing on my end (3 pass, 17 failed). is this ok?

regards,
Nick

@TrN003
Copy link
Author

TrN003 commented May 15, 2023

@serhatbolsu ? any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant