Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favored Characters stored within FurnitureSetDetail object #16

Merged
merged 3 commits into from
May 21, 2024

Conversation

Alex-Gideon
Copy link
Contributor

Hello! I wrote to you on Discord a bit ago asking if there was a function to fetch the list of characters who "favor" a gift set. I didn't see it implemented anywhere, so I wrote a brief implementation that stores the IDs of the characters the set counts as favored.

When converting the data dictionary in client.py fetch_furniture_set_detail(), it converts the dictionary of character IDs and images to a list of just the IDs by checking the key 'favoriteNpcList.'

I was interested in this functionality as I was going to build an excellent way to display which furniture sets would yield the most rewards for the fewest crafts, given a list of obtained characters and an inventory of furnishings.

This is my first time contributing to an active project so I apologize if I did something wrong.

Thanks!

@seriaati
Copy link
Owner

Thank you for your contribution!

@seriaati seriaati merged commit 5b29ca0 into seriaati:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants