Favored Characters stored within FurnitureSetDetail object #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I wrote to you on Discord a bit ago asking if there was a function to fetch the list of characters who "favor" a gift set. I didn't see it implemented anywhere, so I wrote a brief implementation that stores the IDs of the characters the set counts as favored.
When converting the data dictionary in client.py fetch_furniture_set_detail(), it converts the dictionary of character IDs and images to a list of just the IDs by checking the key 'favoriteNpcList.'
I was interested in this functionality as I was going to build an excellent way to display which furniture sets would yield the most rewards for the fewest crafts, given a list of obtained characters and an inventory of furnishings.
This is my first time contributing to an active project so I apologize if I did something wrong.
Thanks!