Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discarded default values in enums require immediate reconstruction #6

Open
feldentm opened this issue Aug 21, 2021 · 4 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@feldentm
Copy link
Contributor

If a block is discarded for an enum, that block has to be reconstructed from the file's default value on read.
This is different from other types as the default value is not not constant for enums.

@feldentm feldentm added the bug Something isn't working label Aug 21, 2021
@feldentm
Copy link
Contributor Author

Note: This is only relevant, if the OGSS least name of an enum member differs for the file and the tool specification.
Therefore, an easy workaround and almost always applicable workaround is not to use change tolerance with enums.

@feldentm
Copy link
Contributor Author

feldentm commented Jun 30, 2023

This should be fixed for distributed fields in Java.

@feldentm
Copy link
Contributor Author

The issue should be fixed for distributed fields in C++

@feldentm feldentm added the good first issue Good for newcomers label Jul 4, 2023
@feldentm
Copy link
Contributor Author

feldentm commented Jul 4, 2023

The issue is mostly fixed in C++. The workaround initialization from the code generator should be removed and a proper initialization should be performed by the parser skipping over already initialized blocks. There are comments for this in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant