Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing the assembly #19

Closed
nshayanfar opened this issue Mar 30, 2022 · 5 comments
Closed

Signing the assembly #19

nshayanfar opened this issue Mar 30, 2022 · 5 comments
Labels
bug Something isn't working
Milestone

Comments

@nshayanfar
Copy link

I have a strongly-named assembly which i would like to use your library in. But in order to do that the references must also be strong-named. Would you consider signing global log context?

@augustoproiete
Copy link
Member

augustoproiete commented Mar 30, 2022

@nshayanfar The assembly is strong-name signed... What issues do you see when you try to use it?

@augustoproiete
Copy link
Member

@nshayanfar Feel free to reopen if you see any issue

https://nuget.info/packages/Serilog.Enrichers.GlobalLogContext/1.1.0

image

@augustoproiete augustoproiete added the invalid This doesn't seem right label Apr 5, 2022
@RuslanLatsina
Copy link

Hi @augustoproiete I have an issue to use your package with PowerPoint VSTO project Net472: The error says that there are issues with the signed package. Can you look at it?

image

Note: Somehow I could reproduce it only with VSTO project

@augustoproiete
Copy link
Member

Thanks for reporting this error @RuslanLatsina! Could you please create a new issue specific for this, and include a sample project that reproduces this? Also, please let me know if your PowerPoint is 32-bit or 64-bit

@augustoproiete augustoproiete added bug Something isn't working and removed invalid This doesn't seem right labels Sep 1, 2022
@augustoproiete augustoproiete added this to the v2.0.0 milestone Sep 1, 2022
@augustoproiete
Copy link
Member

🎉 The changes implemented in response to this issue shipped with Serilog.Enrichers.GlobalLogContext v2.0.0

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants