Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSTO project - not able to use GlobalContext which referenced as Nuget package #27

Closed
RuslanLatsina opened this issue Jun 8, 2022 · 2 comments · Fixed by #29
Closed
Labels
bug Something isn't working
Milestone

Comments

@RuslanLatsina
Copy link

I have an issue to use your package with PowerPoint VSTO project Net472: The error says that there are issues with the signed package.
image

Test project:

PowerPointAddIn_GlobalLogContext.zip

Test environment: Windows 10 64 bit, Powerpoint 16 64bit
image

@sra-michaelgold
Copy link

sra-michaelgold commented Sep 1, 2022

same issue here for netstandard2.0 reference

I'm unable to use my ClickOnce application which uses Serilog.Enrichers.GlobalLogContext.dll because the strong name validation fails on this dll when the application is installed.

Reproduction
run from VS command prompt:
`C:\Users\me.nuget\packages\serilog.enrichers.globallogcontext\1.1.0\lib\netstandard2.0>sn -v Serilog.Enrichers.GlobalLogContext.dll

Microsoft (R) .NET Framework Strong Name Utility Version 4.0.30319.0
Copyright (c) Microsoft Corporation. All rights reserved.

Failed to verify assembly -- Strong name validation failed.
`

Expected behavior
Strong name validation passes (or assembly is not strong named)

Relevant package, tooling and runtime versions
using VS2022

@augustoproiete augustoproiete added the bug Something isn't working label Sep 1, 2022
@augustoproiete augustoproiete added this to the v2.0.0 milestone Sep 1, 2022
@augustoproiete
Copy link
Member

🎉 The changes implemented in response to this issue shipped with Serilog.Enrichers.GlobalLogContext v2.0.0

The release is available on:

@augustoproiete augustoproiete changed the title VSTO project - not able to use GlobalContext which referenced as Nuget package. VSTO project - not able to use GlobalContext which referenced as Nuget package Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

3 participants