Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serilog.Enrichers.GlobalLogContext.dll Strong named validation failed #28

Closed
augustoproiete opened this issue Sep 1, 2022 · 1 comment · Fixed by #29
Closed

Serilog.Enrichers.GlobalLogContext.dll Strong named validation failed #28

augustoproiete opened this issue Sep 1, 2022 · 1 comment · Fixed by #29
Assignees
Labels
bug Something isn't working
Milestone

Comments

@augustoproiete
Copy link
Member

from serilog/serilog#1743 reported by @sra-michaelgold

I'm unable to use my ClickOnce application which uses Serilog.Enrichers.GlobalLogContext.dll because the strong name validation fails on this dll when the application is installed.

Repro

run from VS command prompt:

C:\Users\me\.nuget\packages\serilog.enrichers.globallogcontext\1.1.0\lib\netstandard2.0>sn -v Serilog.Enrichers.GlobalLogContext.dll

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Failed to verify assembly -- Strong name validation failed.

Expected behavior

Strong name validation passes (or assembly is not strong named)

Relevant package, tooling and runtime versions

using VS2022

@augustoproiete augustoproiete added the bug Something isn't working label Sep 1, 2022
@augustoproiete augustoproiete added this to the v2.0.0 milestone Sep 1, 2022
@augustoproiete
Copy link
Member Author

🎉 The changes implemented in response to this issue shipped with Serilog.Enrichers.GlobalLogContext v2.0.0

The release is available on:

@augustoproiete augustoproiete self-assigned this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant