Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibility to translate properties to a part of message #80

Closed
mishamyte opened this issue Jan 16, 2022 · 1 comment · Fixed by #101
Closed

Possibility to translate properties to a part of message #80

mishamyte opened this issue Jan 16, 2022 · 1 comment · Fixed by #101
Labels
enhancement New feature or request
Milestone
v8.0.0

Comments

@mishamyte
Copy link
Member

I would like to keep the properties with the interface of ILogger used throughout the code as all other sinks work properly, but would like to be able to tell the GrafanaLoki that for example TraceId property should not be a grafana label, rather, it should be appended to the message. This way, I sill keep the functionality of the ILogger, and have the performance of the Loki. For example, it is done in Serilog.Sinks.Loki - https://github.com/JosephWoodward/Serilog-Sinks-Loki/blob/master/src/Serilog.Sinks.Loki/LokiBatchFormatter.cs#L147

Originally posted by @X-7r3em in #78 (comment)
@mishamyte mishamyte added documentation Improvements or additions to documentation enhancement New feature or request investigation needed The investigation is needed labels Jan 16, 2022
@mishamyte mishamyte added this to the Backlog milestone Jan 16, 2022
@mishamyte mishamyte mentioned this issue Jan 16, 2022
Closed
@mishamyte mishamyte mentioned this issue Apr 1, 2022
Merged
@mishamyte
Copy link
Member Author

I think this behavior is covered by LokiJsonTextFormatter and labels/properties splitting behavior, started from v8.0.0-beta.0

@mishamyte mishamyte removed documentation Improvements or additions to documentation investigation needed The investigation is needed labels Apr 1, 2022
@mishamyte mishamyte modified the milestones: Backlog, v8.0.0 Apr 1, 2022
@mishamyte mishamyte linked a pull request Apr 1, 2022 that will close this issue
Release v8 features #101
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
v8.0.0
Development

Successfully merging a pull request may close this issue.

Release v8 features serilog-contrib/serilog-sinks-grafana-loki
1 participant
@mishamyte