Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign concept of mapping to labels #98

Closed
mishamyte opened this issue Mar 31, 2022 · 1 comment · Fixed by #101
Closed

Redesign concept of mapping to labels #98

mishamyte opened this issue Mar 31, 2022 · 1 comment · Fixed by #101
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@mishamyte
Copy link
Member

Now concept of filters is unusable in 3/4 cases

And as it is told in #81 (comment):

  1. Can you imagine any case when filtrationMode = null will be a desired behaviour? I doubt it and right now this is a default value. Because filtration implies some performance impact I would make this entire feature to be optional. Would be great to say "I do not need automatic labeling at all."
@mishamyte mishamyte added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 31, 2022
@mishamyte mishamyte added this to the v8.0.0 milestone Mar 31, 2022
@mishamyte mishamyte self-assigned this Mar 31, 2022
@mishamyte
Copy link
Member Author

mishamyte commented Mar 31, 2022

Concept implemented in early versions of v8:

  • Filtering removed
  • Labels behavior is unchanged: global label always translated as label (cause it is defined explicitly)
  • Now user defines the list of prop's names which will be translated to labels. The would not appear in message body to avoid duplication (the same as now)
  • Global label has more priority that mapped from property:

I.E. global label: Some: 42
Log.Information("{Some}", "word")

Result:
Some: 42

@mishamyte mishamyte linked a pull request Apr 1, 2022 that will close this issue
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant