You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I experienced some issues with sending logs in my test project. It's just simple console project and last line of code is responsible for sending logs. In most cases logs are not send. I was very confused first time so I investigated sink code and I found this. I think it's because of async void Emit which is basically fire and forget method. According to my knowledge async void is construction designed only for event handlers and in others cases may be not stable. IMHO it should be just void method and logs should be send synchronously but correct me if I'm wrong.
Hello!
I experienced some issues with sending logs in my test project. It's just simple console project and last line of code is responsible for sending logs. In most cases logs are not send. I was very confused first time so I investigated sink code and I found this. I think it's because of
async void Emit
which is basically fire and forget method. According to my knowledgeasync void
is construction designed only for event handlers and in others cases may be not stable. IMHO it should be just void method and logs should be send synchronously but correct me if I'm wrong.Here are some references:
I'm happy to help and do some PR but first I want to know your opinion 😄
BTW Thanks for great sink! It's fantastic to use composition of graylog and serilog and it's thanks to your work!
The text was updated successfully, but these errors were encountered: