Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock the assembly version #119

Closed
SimonCropp opened this issue Aug 21, 2019 · 3 comments
Closed

Unlock the assembly version #119

SimonCropp opened this issue Aug 21, 2019 · 3 comments

Comments

@SimonCropp
Copy link
Contributor

https://github.com/serilog/serilog-aspnetcore/blob/dev/src/Serilog.AspNetCore/Properties/AssemblyInfo.cs#L4

@nblumhardt
Copy link
Member

It can probably be unlocked, now; this dates back to when binding redirects were causing misery. Less of an issue now, especially since new ASP.NET Core versions aren't targeting .NET Framework.

We still lock Serilog at 2.0 as well, though since it will go on supporting .NET Framework for a lot longer - indefinitely at this stage - we might keep that one locked.

@SimonCropp
Copy link
Contributor Author

yep no worries

@nblumhardt
Copy link
Member

I think we should consider unlocking this one for 3.x 👍

@nblumhardt nblumhardt reopened this Aug 21, 2019
@nblumhardt nblumhardt changed the title is the assembly version locked on purpose? Unlock the assembly version Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants