-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CreateBootstrapLogger no longer available in .NET Standard 2.1 since 8.0.0 #82
Comments
Do you have a Can you retarget it to In other words, can you share some more context as to why this is a must-have for you please? Ultimately if the diff to re-add it is reasonable, and there is a solid case for why a significant cohort of people would not be able to do something desirable, reinstatement is not necessarily off the table - the general principles here are outlined in serilog/serilog#1970 but they are guidelines/principles, not absolutes |
Just to add to @bartelink's reply; this package and the other .Extensions-related ones use a different versioning policy to the rest of the Serilog packages, following their Microsoft.* dependencies exactly (or so the hope goes): https://github.com/serilog/serilog-extensions-hosting#versioning This came out of many and varied confusing issues supporting anything different, so while I think serilog/serilog#1970 is the way forward for the rest of Unfortunately this does lead to issues like this one, sorry this was disruptive! |
Well yeah, it's in the title and description: I am using CreateBootstrapLogger to set up a basic logger for a generic host in a shared C# library (-> .NET Standard). I am not sure if I actually need this functionality (to automatically reload the logger after runtime/host configuration) at all, but it is the only library in my project, that bumps the target framework from .NET Standard 2.0 to 2.1 (you disable reloading for .NET Standard 2.0 in this project). I mean, if I can avoid it, I try not to target serveral frameworks if I can choose .NET Standard in my project - single compilation & less headaches. |
Thanks for the update. I think Nick's policy makes sense so if you can work around it somehow, that's for the best. The thinking behind my questioning was to explore:
And I can definitely appreciate not having to add a TFM to multi-target, serilog/serilog#1970 and this lib are all seeking to limit that, both from a compile time/storage space perspective, but equally from the point of view of limiting how much egregious stuff you need to wade through to troubleshoot scenarios Assuming you can find a reasonable workaround, can the issue be closed on the basis Nick outlined? |
Are you reading my message? I stated precisely why I am using .NET Standard 2.1 instead of 2.0 there. I am using CreateBootstrapLogger, which creates a ReloadableLogger: serilog-extensions-hosting/src/Serilog.Extensions.Hosting/LoggerConfigurationExtensions.cs Lines 37 to 40 in 2b8e221
The ReloadableLogger class is only available, when serilog-extensions-hosting/src/Serilog.Extensions.Hosting/Extensions/Hosting/ReloadableLogger.cs Line 15 in 2b8e221
serilog-extensions-hosting/src/Serilog.Extensions.Hosting/Serilog.Extensions.Hosting.csproj Lines 28 to 30 in 2b8e221
Also, .NET Standard 2.1 (the one you dropped) is supported by .NET (Core) |
Are you reading my message? I absolutely understand the mechanics of it. And I appreciate that your code used to work as it was and does not now. And that it will not unless your code changes or the Serilog supported TFMs in V8 change. There is a primary maintainer of this package. He's doing a decent job by some standards: https://www.nuget.org/stats/packages/Serilog.Extensions.Hosting?groupby=Version Nick's response is the overriding concern here. Please consider the reasons he gave for leaving it as it is in formulating a response that's useful for him in deciding whether there is a real unavoidable thing that's been missed which would justify changing the policy here. Again: I am not the maintainer of this package and there's no point beating points into my stupid head or 'winning' a debate with me. |
Microsoft.Extensions.Hosting 8.0.0 targets If you don't re-add support for .NET Standard 2.1, then please go ahead and remove this comment: serilog-extensions-hosting/src/Serilog.Extensions.Hosting/Serilog.Extensions.Hosting.csproj Lines 8 to 10 in 2b8e221
|
Ah, looks like my mistake, here! Seems as though |
Hello there,
in the 8.0.0 release, the target framework
netstandard2.1
was removed (commit f22e3fd), and in turn, support for a reloadable bootstrap logger was removed for any .NET Standard 2.1 project using this library. See also the code snippet below:serilog-extensions-hosting/src/Serilog.Extensions.Hosting/Serilog.Extensions.Hosting.csproj
Lines 28 to 30 in 2b8e221
The text was updated successfully, but these errors were encountered: