New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Great Console Unification #7
Comments
|
I would be OK with printing highlighted JSON, it's easier to copy/paste/manipulate and more predictable for users I think. |
Is the release date for these known, yet? Great work on this! :) |
@frg sorry, no date as yet. With serilog/serilog#977 merged it opens up other sinks to start some required changes. |
Hoping to have some time to push this forward in the next day or two, but it'll be a while until it's ready. There are some non-trivial weaknesses in |
@nblumhardt Great news! |
On NuGet now in |
Any and all testing/validation appreciated, BTW :-) |
Time flies ...last time i've looked at these V2 was breaking our V1 things ... and here we are ... V3, and we didn't have the time to update :) |
From serilog-archive/serilog-sinks-literate#17.
We've now had experience with three different console sink designs, this one,
ColoredConsole
andLiterateConsole
.Each has strengths and weaknesses; for example, literate has nice presentation, but
Console
can accept a custom formatter and produce valid JSON if required.It's time to unify all of these. There are, as always, options. A strawman proposal:
WriteTo.LiterateConsole()
andWriteTo.ColoredConsole()
, and the corresponding NuGet packages, obsolete, directing users toWriteTo.Console()
Things I think we want without doubt:
ITextFormatter
, culturecmd.exe
,bash
(dark) andPowerShell
(default blue) terminalsLiterateConsole
andColoredConsole
might use Windows ones by default, but we'd strongly encourage ANSI through docs/examples){Properties}
{Message:l}
(this would probably be in the default template, since color would also be on by default, making property value delimiters ("
) redundantStretch/later goals:
Type
)Other thoughts:
StructureValue
, or would the output be more predictable/meaningful for people if we instead printed complex values as (syntax-highlighted) JSON?The text was updated successfully, but these errors were encountered: