Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyValuePairSettings : support non "assembly-qualified" typenames #1065

Closed
tsimbalar opened this issue Nov 23, 2017 · 1 comment
Closed

KeyValuePairSettings : support non "assembly-qualified" typenames #1065

tsimbalar opened this issue Nov 23, 2017 · 1 comment

Comments

@tsimbalar
Copy link
Member

I am creating this issue as a result of comments on #1064 (comment)

For settings whose type is an interface or an abstract class, we allow to pass a value that is :

When the containing assembly is Serilog, it is actually not necessary to add the assembly part in the fulle type name.

It would be nicer and more user-friendly to allow to omit the assembly part of the full type name when either of the following is true :

  • a usingis already present in the settings
  • the assembly is already loaded

This would allow to replace

  • "Serilog.Tests.Support.DummyConcreteClassWithoutDefaultConstructor, Serilog.Tests" with "Serilog.Tests.Support.DummyConcreteClassWithoutDefaultConstructor"
  • "NameSpace.To.ConcreteType::StaticProperty, AssemblyName" with "NameSpace.To.ConcreteType::StaticProperty"
@tsimbalar tsimbalar changed the title KeyValuePairSettings : support non "assembly-qualified typenames" KeyValuePairSettings : support non "assembly-qualified" typenames Nov 23, 2017
@nblumhardt nblumhardt added this to the 3.0.0 milestone May 30, 2019
@nblumhardt
Copy link
Member

I'm working through open issues and closing most of those that have no activity in the past 12 months as stale. This helps us track and prioritize the issues that have the most impact.

If you believe that this issue still needs attention, please feel free to comment here. Thanks!

@nblumhardt nblumhardt removed this from the 3.0.0 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants