Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin AssemblyVersion #1996

Closed
nblumhardt opened this issue Jan 10, 2024 · 4 comments · Fixed by #2015
Closed

Unpin AssemblyVersion #1996

nblumhardt opened this issue Jan 10, 2024 · 4 comments · Fixed by #2015

Comments

@nblumhardt
Copy link
Member

Came here via serilog/serilog-extensions-logging#238

The strategy of pinning our assembly version to 2.0.0.0 forever was very successful in the era of binding-redirect-misery. Times have changed, tools have improved, and now I think it's no longer pulling its weight.

In 4.x, let's consider unpinnig, and just use precise versions for the assembly.

@avichay-kardash
Copy link

Hello,
Using .net 4.7.2 and Serilog 3.1.1, our application encounters the same issue as described on serilog-extensions-logging

How difficult would it be to create a new version of Serilog (3.1.2) with unpinned assembly version 2.0.0.0?

@nblumhardt
Copy link
Member Author

@avichay-kardash unfortunately this change will result in some non-trivial breakage in consuming projects; I've just opened PR #2015 to get the 4.0 ball rolling, which is the best we can do, I think.

@avichay-kardash
Copy link

Thank you @nblumhardt
Is there an ETA for version 4.0?

@nblumhardt
Copy link
Member Author

@avichay-kardash not at this stage, unfortunately. The prerelease version on NuGet is pretty much exactly 3.1.1 with an unpinned assembly version, so it'd reasonable to pull that in if you're able to in a pinch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants