Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected the usage method of obtaining PluginService and PluginConfig in existing plug-ins. #1239

Closed
2 tasks done
luanwenfei-venus opened this issue Jul 5, 2023 · 0 comments
Closed
2 tasks done

Corrected the usage method of obtaining PluginService and PluginConfig in existing plug-ins. #1239

luanwenfei-venus opened this issue Jul 5, 2023 · 0 comments
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Milestone
v1.2.0

Comments

@luanwenfei-venus
Copy link
Collaborator

luanwenfei-venus commented Jul 5, 2023 •
edited by kkf1

What would you like to be added?

  • Corrected the method of obtaining PluginService in each plug-in from ServiceManager::getService to PluginServiceManager::getService
  • Corrected the method of obtaining PluginConfig in each plug-in from ConfigManager::getConfig to PluginConfigManager::getConfig

Why is this needed?

This problem is a legacy issue from versions 1.1.0 and forward. No attention was paid to the restrictions in the implementation of the plug-in service manager and plug-in configuration manager, which resulted in it being used casually in plug-in development. This resulted in subsequent evolution being affected, and the problem was not Facilitates unitized management of plug-ins and frameworks
@luanwenfei-venus luanwenfei-venus added area/plugin Issues or PRs releated to sermant plugin service kind/refactor labels Jul 5, 2023
@luanwenfei-venus luanwenfei-venus added this to the v1.2.0 milestone Jul 5, 2023
@luanwenfei-venus luanwenfei-venus mentioned this issue Jul 5, 2023
Merged
@luanwenfei-venus luanwenfei-venus modified the milestones: v1.2.0, v1.1.0 Jul 6, 2023
@luanwenfei-venus luanwenfei-venus added the kind/enhancement Issues or PRs releated to sermant enhancement label Sep 28, 2023
@kkf1 kkf1 changed the title 修正存量插件中获取PluginService和PluginConfig的使用方式 Corrected the usage method of obtaining PluginService and PluginConfig in existing plug-ins. Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugin Issues or PRs releated to sermant plugin service kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@luanwenfei-venus