fixed the Makefile in demo && fixed the readme #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks you very much for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers,
There was a bug in the Makefile under demo directory. I was able to fix it and also updated the commands in the readme file for quick installation. Following were the errors I was getting before the fix. It was failing at make run command. Since there was only one file to be copied, it was copying it as a file called "lib" rather than copying a file under the newly created "lib" directory. The quick installation commands are also updated in the Makefile under demo directory so you should be able to execute it properly.
It runs successfully post fix as in the following screenshot.
Please review and accept my pull request.
Thank you.