This repository has been archived by the owner on Mar 31, 2024. It is now read-only.
Add path types #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the path type annotations are completely ignored. This commit is just about switching from string -> PathDefinition structs in the various path collection related routines. Depends on identically named branch in moss-format. Signed-off-by: Rune Morling <ermo@serpentos.com>
Signed-off-by: Rune Morling <ermo@serpentos.com>
Tweak logging to use compile time format strings. Signed-off-by: Rune Morling <ermo@serpentos.com>
Signed-off-by: Rune Morling <ermo@serpentos.com>
Add suitable debug traces where appropriate to help introspect PathDefinitions, CollectionRules and packageTarget matches. Signed-off-by: Rune Morling <ermo@serpentos.com>
Signed-off-by: Rune Morling <ermo@serpentos.com>
Signed-off-by: Rune Morling <ermo@serpentos.com>
Signed-off-by: Rune Morling <ermo@serpentos.com>
Signed-off-by: Rune Morling <ermo@serpentos.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need to be merged in lock-step with the moss-format add-path-types branch.
Closes #1