Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decomp/extract do not respect payload data checksum #45

Closed
ikeycode opened this issue Sep 27, 2023 · 1 comment
Closed

Decomp/extract do not respect payload data checksum #45

ikeycode opened this issue Sep 27, 2023 · 1 comment
Labels
type: bug Something isn't working.

Comments

@ikeycode
Copy link
Member

Each payload header in v1 format contains an 8-byte checksum that is currently ignored.

This uses XXH3_64 and is internally stored as XXH64_canonical_t. While reading from the payload, an adapter should be used to build the checksum and compare the hashsum.

Alternatively a read-ahead checksum can be implemented when using mmap by pushing the entire payload-body into a digest.

@tarkah
Copy link
Collaborator

tarkah commented Dec 18, 2023

@tarkah tarkah closed this as completed Dec 18, 2023
@ermo ermo added the type: bug Something isn't working. label Apr 23, 2024
@ermo ermo added this to the oxide-prealpha1 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working.
Projects
Development

No branches or pull requests

3 participants