Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localizing counterLabel #11

Merged
merged 2 commits into from Sep 3, 2017
Merged

Localizing counterLabel #11

merged 2 commits into from Sep 3, 2017

Conversation

i3li
Copy link

@i3li i3li commented Aug 27, 2017 •
edited

This includes:

  • Localizing the number on counterLabel.
  • Changing the counterLabel text alignment to work well on both left to right and right to left layouts.

Before on right to left layouts:
screen shot 2017-08-27 at 7 31 37 am
Notice how the number is very close to the edge of the text field, that because of the text alignment.

After:
screen shot 2017-08-27 at 7 42 40 am

@i3li i3li closed this Aug 27, 2017
@i3li i3li reopened this Aug 27, 2017
@serralvo
Copy link
Owner

@i3li This is really awesome! I'll check it asap, thank you.

@serralvo
Copy link
Owner

serralvo commented Sep 3, 2017

@i3li I checked changes and its ok, merged 👍

@serralvo serralvo merged commit 41a66fa into serralvo:master Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@i3li @serralvo