Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plural string for 1 of thing (e.g. "1 months") #16

Closed
adambowles opened this issue Jun 5, 2017 · 8 comments
Closed

Plural string for 1 of thing (e.g. "1 months") #16

adambowles opened this issue Jun 5, 2017 · 8 comments

Comments

@adambowles
Copy link

Example can be seen in your example gif

@adambowles
Copy link
Author

I recommend using moment to manage this for you

@Sertion
Copy link
Owner

Sertion commented Jun 5, 2017

Hey Adam, thank you for the issue and PR!

Right now there is a token for moments timeFrom function: ${time.from}

I will look into fixing the plural/singular issue.

@Sertion
Copy link
Owner

Sertion commented Jun 5, 2017

I just got back home and started looking into this.

Is this still an issue or is it only an issue in the demo gif?

@adambowles
Copy link
Author

Yeah it's currently in 1.10.0, it was just easier to use the gif to demonstrate visually

@Sertion
Copy link
Owner

Sertion commented Jun 5, 2017

But only for months, right?

Will release a new version after some further testing.

@adambowles
Copy link
Author

Not just 'months'; you can see all time units have plurals here

@Sertion Sertion closed this as completed in 5ad5873 Jun 5, 2017
@Sertion
Copy link
Owner

Sertion commented Jun 5, 2017

Thanks for being persistent here. For some reason I thought it never could render with one day or one hour.

@adambowles
Copy link
Author

No problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants