Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMBA_VOLUME_CONFIG_ should support colons #74

Closed
Tydus opened this issue Dec 5, 2022 · 4 comments
Closed

SAMBA_VOLUME_CONFIG_ should support colons #74

Tydus opened this issue Dec 5, 2022 · 4 comments

Comments

@Tydus
Copy link

Tydus commented Dec 5, 2022

Thanks for the great work! I especially like the idea of storing users' (hashed) passwords directly into the compose.yaml.

Currently, the space character in the global config key is specially handled, but sometimes we need colons(:) in the key as well.

FYI: fruit:nfs_aces needs to be in the section [global] in order to work.
https://www.samba.org/samba/docs/current/man-html/vfs_fruit.8.html

Or, we can just support putting custom global config into one key, just like in SAMBA_VOLUME_CONFIG_.

@MarvAmBass
Copy link
Member

thanks! I'll take a look! maybe I use some special escape sequence like _COLON_ -> I already to something similar for spaces

@Tydus
Copy link
Author

Tydus commented Dec 5, 2022

Wow that's fast!

Yeah, definitely _COLON_ will do the trick. Waiting for your good news!

@MarvAmBass
Copy link
Member

it's building already, I'll push the github release once it's pushed to docker registry ;)

MarvAmBass added a commit that referenced this issue Dec 5, 2022
@MarvAmBass
Copy link
Member

it's available in docker hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants