Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel upstream requests when clients go away #38

Closed
ignoramous opened this issue Dec 24, 2021 · 1 comment
Closed

Cancel upstream requests when clients go away #38

ignoramous opened this issue Dec 24, 2021 · 1 comment

Comments

@ignoramous
Copy link
Contributor

Sometimes, clients close connections even before a response could be sent. In those cases, it may be better to close upstream connections as there's no one to send an answer to, but then again if the client comes back again with the same query, we could possibly respond faster since the response would have been cached from previous request...

Eitherways, any behaviour, one way or the other, needs to be codified (documented or implemented).

@ignoramous
Copy link
Contributor Author

ignoramous commented Jan 22, 2022

Since we cache responses, it is okay for clients to go away... The caches would be primed for when they come back (assuming TTLs are within range).

Recent refactor has introduced timeouts too (e566bbd), that actually work. The min timeout is 4s while max is 30s (33e9107). 10s is the default timeout set on all platforms (1bdd319), though deployments are free to override those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant