deno DoH: Blocking not working

[amithm7]

doh -k facebook.com https://dns.rethinkdns.localhost:8080/1:4AcHAP__________-f8\=

should be blocked, but isn't.

[amithm7]

Something here is losing the config / url?

serverless-dns/src/server-deno.ts

Lines 106 to 110 in 33500e9

	// doc.deno.land/deno/stable/~/Deno.RequestEvent
	// deno.land/manual/runtime/http_server_apis#http-requests-and-responses
	const req = requestEvent.request as Request;
	const rw = requestEvent.respondWith.bind(requestEvent) as Function;
	res = handleRequest(mkFetchEvent(req, rw));

This is the only change I see...

Also, type assertion (as Type) isn't required on line 108 & 109 as there is no ambiguity.

[ignoramous]

The "blocklist" Map was always adjudged "empty" on Deno (and hence blocking didn't work), because of this line of code:

serverless-dns/src/commons/util.js

Line 315 in 1b60d56

if (!m.__proto__.hasOwnProperty("size")) return true;

Seems like __proto__ isn't Deno's cup of tea...

[ignoramous]

Blocks should be up and running on Deno now: 881d891

[amithm7]

@ignoramous yes, blocking works on deno now, but node/ fly is broken with that commit: https://github.com/serverless-dns/serverless-dns/runs/4924780290?check_suite_focus=true

[ignoramous]

Fixed: 15f5df6 Thanks. :D