Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-at-edge): handle /_next/static image requests and minor improvements to image error logging #1288

Merged
merged 7 commits into from
Jun 23, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jun 23, 2021

May fix: #1285

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #1288 (27a33ea) into master (9af3a37) will increase coverage by 0.45%.
The diff coverage is 80.00%.

❗ Current head 27a33ea differs from pull request most recent head 0b49af8. Consider uploading reports for the commit 0b49af8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
+ Coverage   83.35%   83.81%   +0.45%     
==========================================
  Files          97       97              
  Lines        3299     3300       +1     
  Branches      956      958       +2     
==========================================
+ Hits         2750     2766      +16     
+ Misses        484      469      -15     
  Partials       65       65              
Impacted Files Coverage Δ
...s/libs/lambda-at-edge/src/images/imageOptimizer.ts 80.82% <80.00%> (+5.13%) ⬆️
...ages/libs/lambda-at-edge/src/images/serveStatic.ts 80.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af3a37...0b49af8. Read the comment docs.

@dphang dphang merged commit b64effe into master Jun 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/fix-next-static-s3-key branch June 23, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next 11 image component
1 participant