Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs-component, aws-lambda): support adding tags to lambdas #1300

Merged
merged 7 commits into from
Jun 26, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Jun 26, 2021

Will add the other resource tagging in separate PR

@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #1300 (656122e) into master (e824146) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 656122e differs from pull request most recent head 9976f4b. Consider uploading reports for the commit 9976f4b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
+ Coverage   83.90%   83.94%   +0.04%     
==========================================
  Files          97       97              
  Lines        3317     3327      +10     
  Branches      968      973       +5     
==========================================
+ Hits         2783     2793      +10     
  Misses        469      469              
  Partials       65       65              
Impacted Files Coverage Δ
...ges/serverless-components/aws-lambda/serverless.js 73.91% <100.00%> (+0.38%) ⬆️
packages/serverless-components/aws-lambda/utils.js 75.47% <100.00%> (+2.27%) ⬆️
...rless-components/nextjs-component/src/component.ts 90.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e824146...9976f4b. Read the comment docs.

@dphang dphang marked this pull request as ready for review June 26, 2021 07:24
@dphang dphang merged commit 74721c2 into master Jun 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the dphang/lambda-tags branch June 26, 2021 07:25
@dphang dphang mentioned this pull request Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant