domainName should be checked before replacing

[peniakoff]

Issue has been described here: #1381

[dphang]

I believe this is the automated Codacy suggestion (though it doesn't seem correct?), though the code build itself was also failing due to type errors, so that might be why it made that suggestion.

[dphang]

Looks like some unit tests have failed. E.g previously was expecting:

"Bucket": "my-bucket.s3.amazonaws.com"

but now bucket is my-bucket (so technically it is correct now). Please fix and then I will approve it.

[slsnextbot]

Handler Size Report

There are changes to handler sizes. Please review.

Base Handler Sizes (kB) (commit 28c8bd6)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1231,
            "Minified": 435
        },
        "API Lambda": {
            "Standard": 85,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 903,
            "Minified": 357
        },
        "Regeneration Lambda": {
            "Standard": 629,
            "Minified": 223
        }
    }
}

New Handler Sizes (kB) (commit 3be15e4)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1226,
            "Minified": 432
        },
        "API Lambda": {
            "Standard": 86,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 894,
            "Minified": 354
        },
        "Regeneration Lambda": {
            "Standard": 620,
            "Minified": 220
        }
    }
}

[codecov]

Codecov Report

Merging #1382 (8794c73) into master (28c8bd6) will increase coverage by 0.27%.
The diff coverage is 87.17%.

❗ Current head 8794c73 differs from pull request most recent head 3be15e4. Consider uploading reports for the commit 3be15e4 to get more accurate results

@@            Coverage Diff             @@
##           master    #1382      +/-   ##
==========================================
+ Coverage   83.86%   84.14%   +0.27%     
==========================================
  Files          97       96       -1     
  Lines        3371     3367       -4     
  Branches     1001      995       -6     
==========================================
+ Hits         2827     2833       +6     
+ Misses        482      474       -8     
+ Partials       62       60       -2     

Impacted Files	Coverage Δ
...s/libs/lambda-at-edge/src/images/imageOptimizer.ts	81.27% <ø> (ø)
...ambda-at-edge/src/lib/triggerStaticRegeneration.ts	100.00% <ø> (ø)
packages/libs/lambda-at-edge/src/s3/s3StorePage.ts	90.47% <ø> (ø)
...ackages/libs/lambda-at-edge/src/default-handler.ts	89.09% <63.63%> (+1.09%)	⬆️
packages/libs/core/src/handle/fallback.ts	97.22% <92.85%> (+0.92%)	⬆️
...ayers/lambda-at-edge-compat/next-aws-cloudfront.js	100.00% <100.00%> (ø)
packages/libs/core/src/build/index.ts	95.18% <100.00%> (+0.24%)	⬆️
packages/libs/core/src/route/data.ts	100.00% <100.00%> (ø)
packages/libs/core/src/route/page.ts	100.00% <100.00%> (ø)
...bda-at-edge/src/s3/s3BucketNameFromEventRequest.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c8bd6...3be15e4. Read the comment docs.

[dphang]

Manually ran e2e tests here: https://github.com/serverless-nextjs/serverless-next.js/actions/runs/1013949580. Will merge after it passes.