Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-sqs): support sqs tags/naming #1543

Merged
merged 3 commits into from
Aug 19, 2021
Merged

feat(aws-sqs): support sqs tags/naming #1543

merged 3 commits into from
Aug 19, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Aug 13, 2021

No description provided.

@slsnextbot
Copy link
Collaborator

slsnextbot commented Aug 13, 2021

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit a898720)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1240,
            "Minified": 439
        },
        "API Lambda": {
            "Standard": 86,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 905,
            "Minified": 358
        },
        "Regeneration Lambda": {
            "Standard": 630,
            "Minified": 225
        }
    }
}

New Handler Sizes (kB) (commit 18786af)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1240,
            "Minified": 439
        },
        "API Lambda": {
            "Standard": 86,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 905,
            "Minified": 358
        },
        "Regeneration Lambda": {
            "Standard": 630,
            "Minified": 225
        }
    }
}

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #1543 (18786af) into master (b0cc4ed) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1543      +/-   ##
==========================================
+ Coverage   84.17%   84.29%   +0.11%     
==========================================
  Files          97       97              
  Lines        3387     3406      +19     
  Branches     1009     1013       +4     
==========================================
+ Hits         2851     2871      +20     
+ Misses        476      475       -1     
  Partials       60       60              
Impacted Files Coverage Δ
...ckages/serverless-components/aws-sqs/serverless.js 93.75% <100.00%> (+0.52%) ⬆️
packages/serverless-components/aws-sqs/utils.js 67.85% <100.00%> (+7.29%) ⬆️
...rless-components/nextjs-component/src/component.ts 90.00% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cc4ed...18786af. Read the comment docs.

@dphang
Copy link
Collaborator Author

dphang commented Aug 19, 2021

problem with the existing test apps, need to take a look later - tested locally and things seem fine (and this doesn't affect runtime stuff anyway), so I'm merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants