Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cloudfront): set tags when creating distribution #1562

Merged
merged 3 commits into from
Aug 21, 2021

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Aug 19, 2021

No description provided.

@dphang dphang marked this pull request as draft August 19, 2021 07:17
@slsnextbot
Copy link
Collaborator

slsnextbot commented Aug 19, 2021

Handler Size Report

No changes to handler sizes.

Base Handler Sizes (kB) (commit eb4267a)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1454,
            "Minified": 510
        },
        "API Lambda": {
            "Standard": 86,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 909,
            "Minified": 360
        },
        "Regeneration Lambda": {
            "Standard": 634,
            "Minified": 227
        }
    }
}

New Handler Sizes (kB) (commit 30d48a7)

{
    "Lambda@Edge": {
        "Default Lambda": {
            "Standard": 1454,
            "Minified": 510
        },
        "API Lambda": {
            "Standard": 86,
            "Minified": 34
        },
        "Image Lambda": {
            "Standard": 909,
            "Minified": 360
        },
        "Regeneration Lambda": {
            "Standard": 634,
            "Minified": 227
        }
    }
}

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #1562 (95d099b) into master (eb4267a) will increase coverage by 0.04%.
The diff coverage is 93.54%.

❗ Current head 95d099b differs from pull request most recent head 30d48a7. Consider uploading reports for the commit 30d48a7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
+ Coverage   84.29%   84.34%   +0.04%     
==========================================
  Files          97       97              
  Lines        3406     3423      +17     
  Branches     1013     1015       +2     
==========================================
+ Hits         2871     2887      +16     
- Misses        475      476       +1     
  Partials       60       60              
Impacted Files Coverage Δ
...serverless-components/aws-cloudfront/test-utils.ts 95.45% <92.30%> (-4.55%) ⬇️
.../serverless-components/aws-cloudfront/src/index.ts 86.11% <92.85%> (+0.08%) ⬆️
...verless-components/aws-cloudfront/src/component.ts 80.95% <100.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4267a...30d48a7. Read the comment docs.

@dphang dphang marked this pull request as ready for review August 21, 2021 05:17
@dphang
Copy link
Collaborator Author

dphang commented Aug 21, 2021

Tested locally and able to deploy next.js from scratch and tags are created upon distribution creation, ignoring the codacy issues for now since they are minor and will take a bit of work to refactor the aws-cloudfront package (originally was in JS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants